[ 
https://issues.apache.org/jira/browse/HADOOP-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890802#comment-17890802
 ] 

ASF GitHub Bot commented on HADOOP-18682:
-----------------------------------------

adoroszlai commented on code in PR #6483:
URL: https://github.com/apache/hadoop/pull/6483#discussion_r1805932485


##########
hadoop-dist/pom.xml:
##########
@@ -29,6 +29,13 @@
   <name>Apache Hadoop Distribution</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <file.encoding>UTF-8</file.encoding>
+    <downloadSources>true</downloadSources>
+    
<docker.hadoop-runner.version>docker-hadoop-3</docker.hadoop-runner.version>

Review Comment:
   No idea why `apache/hadoop-runner` has a version tagged `docker-hadoop-3`, 
but it is the oldest and largest one.  I don't think it should be used.  `jdk8` 
would be a safe choice.
   
   https://hub.docker.com/r/apache/hadoop-runner/tags





> Move hadoop docker scripts under the main source code
> -----------------------------------------------------
>
>                 Key: HADOOP-18682
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18682
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Christos Bisias
>            Priority: Major
>              Labels: pull-request-available
>
> Exploratory:
> Coming from https://github.com/apache/hadoop/pull/5514
> We have docker scripts maintained in a different branch. We can explore them 
> to have as part of dev-support in our main source code.
> They can be used for new users to try the code without the headache of 
> building and doing crazy stuff, and can help in dev testing as well



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to