TaoYang526 commented on code in PR #7121: URL: https://github.com/apache/hadoop/pull/7121#discussion_r1806074629
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/placement/policy/MultiComparatorPolicy.java: ########## @@ -0,0 +1,346 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.placement.policy; + +import org.apache.hadoop.classification.VisibleForTesting; +import org.apache.hadoop.conf.Configurable; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.yarn.exceptions.ConfigurationException; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerNode; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerConfiguration; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.placement.MultiNodeLookupPolicy; +import org.apache.hadoop.yarn.util.resource.DominantResourceCalculator; +import org.apache.hadoop.yarn.util.resource.Resources; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.function.Function; +import java.util.stream.Collectors; + +import static org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerConfiguration.DOT; + +/** + * <p> + * This class has the following functionality: + * + * <p> + * MultiComparatorPolicy + * - manages some common comparators to help sorting nodes by + * allocated/unallocated/total resource, dominant ratio, etc. + * - holds sorted nodes list based on the of nodes at given time. + * - can be configured with specified comparators. + * </p> + */ +public class MultiComparatorPolicy<N extends SchedulerNode> + implements MultiNodeLookupPolicy<N>, Configurable { + + private static final Logger LOG = + LoggerFactory.getLogger(MultiComparatorPolicy.class); + // comparators + private static final DominantResourceCalculator DOMINANT_RC = + new DominantResourceCalculator(); + private static final Map<ComparatorKey, Function<SchedulerNode, Comparable>> + COMPARATOR_CALCULATORS = Collections.unmodifiableMap( + new HashMap<ComparatorKey, Function<SchedulerNode, Comparable>>() {{ + // for vcores + put(ComparatorKey.ALLOCATED_VCORES, + obj -> obj.getAllocatedResource().getVirtualCores()); + put(ComparatorKey.UNALLOCATED_VCORES, + obj -> obj.getUnallocatedResource().getVirtualCores()); + put(ComparatorKey.TOTAL_VCORES, + obj -> obj.getTotalResource().getVirtualCores()); + // for memory + put(ComparatorKey.ALLOCATED_MEMORY, + obj -> obj.getAllocatedResource().getMemorySize()); + put(ComparatorKey.UNALLOCATED_MEMORY, + obj -> obj.getUnallocatedResource().getMemorySize()); + put(ComparatorKey.TOTAL_MEMORY, + obj -> obj.getTotalResource().getMemorySize()); + // for resource + put(ComparatorKey.ALLOCATED_RESOURCE, + SchedulerNode::getAllocatedResource); + put(ComparatorKey.UNALLOCATED_RESOURCE, + SchedulerNode::getUnallocatedResource); + put(ComparatorKey.TOTAL_RESOURCE, + SchedulerNode::getTotalResource); + // for dominant ratio + put(ComparatorKey.DOMINANT_ALLOCATED_RATIO, obj -> Resources + .ratio(DOMINANT_RC, obj.getAllocatedResource(), + obj.getTotalResource())); + // for node ID + put(ComparatorKey.NODE_ID, SchedulerNode::getNodeID); + }}); + // conf keys and default values + public static final String COMPARATORS_CONF_KEY = "comparators"; + protected static final List<Comparator> DEFAULT_COMPARATORS = Collections + .unmodifiableList(Arrays.asList( + new Comparator(ComparatorKey.DOMINANT_ALLOCATED_RATIO, + OrderDirection.ASC, COMPARATOR_CALCULATORS + .get(ComparatorKey.DOMINANT_ALLOCATED_RATIO)), + new Comparator(ComparatorKey.NODE_ID, OrderDirection.ASC, + COMPARATOR_CALCULATORS.get(ComparatorKey.NODE_ID)))); + + protected Map<String, Set<N>> nodesPerPartition = new ConcurrentHashMap<>(); + protected List<Comparator> comparators; + private Configuration conf; + + public MultiComparatorPolicy() { + } + + @Override + public void setConf(Configuration conf) { + // init comparators + this.comparators = DEFAULT_COMPARATORS; + if (conf == null) { + return; + } + this.conf = conf; + String policyName = conf.get( + CapacitySchedulerConfiguration.MULTI_NODE_SORTING_POLICY_CURRENT_NAME); Review Comment: Currently`MULTI_NODE_SORTING_POLICY_NAME` is the prefix of all the configurations of multi-node policy: `yarn.scheduler.capacity.multi-node-sorting.policy`, it's not a proper name but used in many places so I prefer not to update it. `MULTI_NODE_SORTING_POLICY_CURRENT_NAME` is used to transfer the policyName to policy instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
