aQuigs commented on code in PR #7127:
URL: https://github.com/apache/hadoop/pull/7127#discussion_r1813174162
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java:
##########
@@ -1078,6 +1116,10 @@ static BalancerParameters parse(String[] args) {
}
Preconditions.checkArgument(excludedNodes == null || includedNodes
== null,
"-exclude and -include options cannot be specified together.");
+ Preconditions.checkArgument(excludedSourceNodes == null ||
sourceNodes == null,
+ "-exclude and -include options cannot be specified together.");
+ Preconditions.checkArgument(excludedTargetNodes == null ||
targetNodes == null,
+ "-exclude and -include options cannot be specified together.");
Review Comment:
nit: fixup these error messages too for the proper arg name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
