huangzhaobo99 commented on code in PR #7120:
URL: https://github.com/apache/hadoop/pull/7120#discussion_r1817983747
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java:
##########
@@ -1071,6 +1096,12 @@ static BalancerParameters parse(String[] args) {
b.setSortTopNodes(true);
LOG.info("Balancer will sort nodes by" +
" capacity usage percentage to prioritize top used nodes");
+ } else if ("-limitOverUtilizedNum".equalsIgnoreCase(args[i])) {
+ Preconditions.checkArgument(++i < args.length,
+ "limitOverUtilizedNum value is missing: args = " +
Arrays.toString(args));
+ int limitNum = Integer.parseInt(args[i]);
Review Comment:
Fixed, 0 is legal, non-negative numbers are okay.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java:
##########
@@ -120,12 +127,12 @@ public String toString() {
+ " max idle iteration = %s," + " #excluded nodes = %s,"
+ " #included nodes = %s," + " #source nodes = %s,"
+ " #blockpools = %s," + " run during upgrade = %s,"
- + " sort top nodes = %s,"
+ + " sort top nodes = %s," + " limit overUtilized nodes num = %s"
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
