steveloughran commented on PR #7130: URL: https://github.com/apache/hadoop/pull/7130#issuecomment-2441629859
I am not going to be able to review this as it needs people from the hdfs and yarn teams, who services deploy the web servers. That's a quick glance though: * pom.xml-wise: declare the versions of artifacts in hadoop-project/pom.xml; sub-projects projects must not * the move off javax.annotations.@Nullable seems unneeded to me. Why are you doing it? the current one is in findbugs and there shouldn't be any problems with it. If it is impossible to use the current nullable annotation, then we should have our own in hadoop-annotations. That way: we do not need to add Jakarta dependencies onto projects which I've never needed them before, and isolated from future changes. This and should be done independently of the Jakarta move. But I note: I don't think we need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
