[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266075#comment-13266075 ]
Hadoop QA commented on HADOOP-8340: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525207/hadoop-8340.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 javadoc. The javadoc tool appears to have generated 16 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/915//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/915//console This message is automatically generated. > SNAPSHOT build versions should compare as less than their eventual final > release > -------------------------------------------------------------------------------- > > Key: HADOOP-8340 > URL: https://issues.apache.org/jira/browse/HADOOP-8340 > Project: Hadoop Common > Issue Type: Improvement > Components: util > Affects Versions: 2.0.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hadoop-8340.txt, hadoop-8340.txt > > > We recently added a utility function to compare two version strings, based on > splitting on '.'s and comparing each component. However, it considers a > version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, > since SNAPSHOT builds come before the final release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira