KeeProMise commented on code in PR #7139:
URL: https://github.com/apache/hadoop/pull/7139#discussion_r1824401831
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/protocolPB/AsyncRpcProtocolPBUtil.java:
##########
@@ -96,6 +102,38 @@ public static <T, R> R asyncIpcClient(
return asyncReturn(clazz);
}
+ public static <T> void asyncRouterServer(ServerReq<T> req, ServerRes<T> res)
{
+ final ProtobufRpcEngineCallback2 callback =
+ ProtobufRpcEngine2.Server.registerForDeferredResponse2();
+
+ CompletableFuture<Object> completableFuture =
+ CompletableFuture.completedFuture(null);
+ completableFuture.thenCompose(o -> {
Review Comment:
It's better to add some comments
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/protocolPB/RefreshUserMappingsProtocolServerSideTranslatorPB.java:
##########
@@ -32,12 +32,12 @@
public class RefreshUserMappingsProtocolServerSideTranslatorPB implements
RefreshUserMappingsProtocolPB {
private final RefreshUserMappingsProtocol impl;
-
- private final static RefreshUserToGroupsMappingsResponseProto
+
+ protected final static RefreshUserToGroupsMappingsResponseProto
VOID_REFRESH_USER_GROUPS_MAPPING_RESPONSE =
RefreshUserToGroupsMappingsResponseProto.newBuilder().build();
- private final static RefreshSuperUserGroupsConfigurationResponseProto
+ protected final static RefreshSuperUserGroupsConfigurationResponseProto
VOID_REFRESH_SUPERUSER_GROUPS_CONFIGURATION_RESPONSE =
Review Comment:
Hi, @hfutatzhanghb thanks for your contribution! It is recommended not to
modify common because the pipeline will run for a long time. There are only 2
variables here, you can copy them directly to
RouterRefreshUserMappingsProtocolServerSideTranslatorPB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
