PrateekSane commented on code in PR #7123:
URL: https://github.com/apache/hadoop/pull/7123#discussion_r1829884099
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -4738,6 +4738,12 @@ public long getMissingReplOneBlocksCount() {
// not locking
return blockManager.getMissingReplOneBlocksCount();
}
+
+ @Metric({"BadlyDistBlocks", "Number of Badly Distributed Blocks"})
+ public long getBadlyDistributedBlocksCount() {
+ // not locking
+ return blockManager.getBadlyDistributedBlocksCount();
+ }
Review Comment:
I think both are needed since the BlockManager gets the count,
BadlyDistBlocks exposes metric for Metrics2 and theres also
BadlyDistributedBlocks metric for MBean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
