[
https://issues.apache.org/jira/browse/HADOOP-19330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896432#comment-17896432
]
ASF GitHub Bot commented on HADOOP-19330:
-----------------------------------------
steveloughran commented on PR #7151:
URL: https://github.com/apache/hadoop/pull/7151#issuecomment-2462902162
what the log looks like
S3AInputStream
```
2024-11-07 17:50:36,378 [Finalizer] DEBUG s3a.S3AInputStream
(S3AInputStream.java:closeStream(759)) - Closing stream finalize(): abort
2024-11-07 17:50:36,378 [Finalizer] DEBUG impl.SDKStreamDrainer
(SDKStreamDrainer.java:drainOrAbortHttpStream(176)) - drain or abort reason
finalize() remaining=1023 abort=true
2024-11-07 17:50:36,378 [Finalizer] DEBUG impl.SDKStreamDrainer
(SDKStreamDrainer.java:drainOrAbortHttpStream(235)) - Aborting stream
s3a://stevel-london/test/testFinalizer
2024-11-07 17:50:36,380 [Finalizer] DEBUG impl.SDKStreamDrainer
(SDKStreamDrainer.java:drainOrAbortHttpStream(245)) - Stream
s3a://stevel-london/test/testFinalizer aborted: finalize(); remaining=1023
```
new warning log
```
2024-11-07 17:50:36,380 [Finalizer] WARN connection.leaks
(S3AInputStream.java:finalize(292)) - HTTP connection not closed while reading
s3a://stevel-london/test/testFinalizer in thread JUnit-testFinalizer
java.io.IOException: HTTP connection not closed while reading
s3a://stevel-london/test/testFinalizer in thread JUnit-testFinalizer
at
org.apache.hadoop.fs.s3a.S3AInputStream.<init>(S3AInputStream.java:263)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.executeOpen(S3AFileSystem.java:1890)
at org.apache.hadoop.fs.s3a.S3AFileSystem.open(S3AFileSystem.java:1840)
at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:997)
at
org.apache.hadoop.fs.s3a.ITestS3AInputStream.testFinalizer(ITestS3AInputStream.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
```
> S3AInputStream.finalizer to warn if closed with http connection -then release
> it
> --------------------------------------------------------------------------------
>
> Key: HADOOP-19330
> URL: https://issues.apache.org/jira/browse/HADOOP-19330
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> A recurring problem is that applications forget to close their input streams;
> eventually the HTTP connection runs out.
> Having the finalizer close streams during GC will ensure that after a GC the
> http connections are returned. While this is an improvement on today, it is
> insufficient
> * only happens during GC, so may not fix problem entirely
> * doesn't let developers know things are going wrong.
> * doesn't let us differentiate well between stream leak and overloaded FS
> proposed enhancements then
> * collect stack trace in constructor
> * log in finalize at warn including path, thread and stack
> * have special log for this, so it can be turned off in production (libraries
> telling end users off for developer errors is simply an annoyance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
