myandpr commented on PR #7146: URL: https://github.com/apache/hadoop/pull/7146#issuecomment-2470873110
It looks like the CI pipeline hasn’t been applied to the latest code branch. [spotbug](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7146/8/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html) above says that : ``` Code Warning Redundant nullcheck of dns, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType) In class org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer In method org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType) Value loaded from dns Return value of org.apache.hadoop.thirdparty.com.google.common.cache.LoadingCache.get(Object) of type Object Redundant null check at RouterRpcServer.java:[line 1091] ``` However, line 1091 in the current code is https://github.com/apache/hadoop/pull/7146/files#diff-41d25e50b34ba6127e22b21269274dd13c01a339843f2957df4bf173cde51481R1091, and there is no `Redundant null check at RouterRpcServer.java:[line 1091]` as indicated by the bugspot above. I will re-trigger it once. cc: @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
