[
https://issues.apache.org/jira/browse/HADOOP-19143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897615#comment-17897615
]
ASF GitHub Bot commented on HADOOP-19143:
-----------------------------------------
myandpr commented on PR #7146:
URL: https://github.com/apache/hadoop/pull/7146#issuecomment-2470873110
It looks like the CI pipeline hasn’t been applied to the latest code branch.
[spotbug](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7146/8/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html)
above says that :
```
Code Warning
Redundant nullcheck of dns, which is known to be non-null in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType)
In class org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer
In method
org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType)
Value loaded from dns
Return value of
org.apache.hadoop.thirdparty.com.google.common.cache.LoadingCache.get(Object)
of type Object
Redundant null check at RouterRpcServer.java:[line 1091]
```
However, line 1091 in the current code is
https://github.com/apache/hadoop/pull/7146/files#diff-41d25e50b34ba6127e22b21269274dd13c01a339843f2957df4bf173cde51481R1091,
and there is no `Redundant null check at RouterRpcServer.java:[line 1091]` as
indicated by the bugspot above.
I will re-trigger it once. cc: @slfan1989
> Upgrade commons-cli to 1.6.0.
> -----------------------------
>
> Key: HADOOP-19143
> URL: https://issues.apache.org/jira/browse/HADOOP-19143
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, common
> Affects Versions: 3.5.0, 3.4.1
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> commons-cli can be upgraded to 1.6.0, I will try to upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
