szetszwo commented on code in PR #7140:
URL: https://github.com/apache/hadoop/pull/7140#discussion_r1840925600
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/SaslDataTransferServer.java:
##########
@@ -224,21 +225,8 @@ static final class SaslServerCallbackHandler
*/
SaslServerCallbackHandler(Configuration conf, PasswordFunction
passwordFunction) {
this.passwordFunction = passwordFunction;
-
- final Class<?> clazz = conf.getClass(
-
HdfsClientConfigKeys.DFS_DATA_TRANSFER_SASL_CUSTOMIZEDCALLBACKHANDLER_CLASS_KEY,
- CustomizedCallbackHandler.DefaultHandler.class);
- final Object callbackHandler;
- try {
- callbackHandler = clazz.newInstance();
- } catch (Exception e) {
- throw new IllegalStateException("Failed to create a new instance of "
+ clazz, e);
- }
- if (callbackHandler instanceof CustomizedCallbackHandler) {
- customizedCallbackHandler = (CustomizedCallbackHandler)
callbackHandler;
- } else {
- customizedCallbackHandler =
CustomizedCallbackHandler.delegate(callbackHandler);
- }
+ this.customizedCallbackHandler = CustomizedCallbackHandler.get(
+
HdfsClientConfigKeys.DFS_DATA_TRANSFER_SASL_CUSTOMIZEDCALLBACKHANDLER_CLASS_KEY,
conf);
Review Comment:
That's a good idea. Let's use the same conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
