anmolanmol1234 commented on code in PR #7122:
URL: https://github.com/apache/hadoop/pull/7122#discussion_r1843571904
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -286,7 +295,7 @@ void completeExecute(TracingContext tracingContext)
long sleepDuration = 0L;
if (abfsBackoffMetrics != null) {
synchronized (this) {
- abfsBackoffMetrics.incrementTotalNumberOfRequests();
+ abfsBackoffMetrics.incrementMetricValue(TOTAL_NUMBER_OF_REQUESTS);
Review Comment:
Null check not needed for abfsBackOffMetrics ?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -286,7 +295,7 @@ void completeExecute(TracingContext tracingContext)
long sleepDuration = 0L;
if (abfsBackoffMetrics != null) {
synchronized (this) {
- abfsBackoffMetrics.incrementTotalNumberOfRequests();
+ abfsBackoffMetrics.incrementMetricValue(TOTAL_NUMBER_OF_REQUESTS);
Review Comment:
Null check not needed for abfsBackOffMetrics ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
