[
https://issues.apache.org/jira/browse/HADOOP-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899296#comment-17899296
]
ASF GitHub Bot commented on HADOOP-19341:
-----------------------------------------
EungsopYoo commented on code in PR #7168:
URL: https://github.com/apache/hadoop/pull/7168#discussion_r1847443009
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/ElasticByteBufferPool.java:
##########
@@ -36,7 +36,7 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Stable
-public class ElasticByteBufferPool implements ByteBufferPool {
+public abstract class ElasticByteBufferPool implements ByteBufferPool {
Review Comment:
I have tested it; just replace the class, compile with no error, run the
binary, and watch it works as I expected(no direct memory leakage).
But it requires a new test case. I will add some.
> HDFS Client's direct memory leaks with erasure codind enabled
> -------------------------------------------------------------
>
> Key: HADOOP-19341
> URL: https://issues.apache.org/jira/browse/HADOOP-19341
> Project: Hadoop Common
> Issue Type: Bug
> Components: erasure-coding
> Reporter: Eungsop Yoo
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2024-11-18-13-53-23-690.png
>
>
> We are testing erasure coding with HBase. But we faced that the size of
> direct memory of HBase RegionServer keep growing.
> !image-2024-11-18-13-53-23-690.png!
> It is caused by that the direct memory allocated by ElasticByteBufferPool of
> HDFS client is never released.
> https://issues.apache.org/jira/browse/HADOOP-18105
> We found that we already have the solution,
> WeakReferencedElasticByteBufferPool.
> Just replace ElasticByteBufferPool with WeakReferencedElasticByteBufferPool.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
