pxp531 commented on code in PR #5238:
URL: https://github.com/apache/hadoop/pull/5238#discussion_r1849417696
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -717,6 +717,8 @@ public void removeOrTrackCompletedContainersFromContext(
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerState.DONE))
{
context.getContainers().remove(containerId);
removedContainers.add(containerId);
+ // For the finished containers, the residual data stored in leveldb
should also be cleared
+ addCompletedContainer(containerId);
Review Comment:
> Thanks for the explanation, but it's not needed for this operation, it
doesn't seem like what heartbeat is supposed to do,
`NodeStatusUpdaterImpl#addCompletedContainer` already does it, I think it's
enough
When restarting the NM, we encountered an OOM issue during the recovery
process. Upon analyzing the cause of the OOM in the heap memory, we found a
large number of completed containers, approximately 150,000+.
We suspect this is due to improper deletion of data in levelDB. Therefore,
we believe that in addition to the memory deletion, the heartbeat response
should also include a deletion operation for levelDB.
Currently, the heartbeat response only performs memory deletion and does not
handle levelDB deletion, which may lead to inconsistencies between the two
deletion processes. Furthermore, the levelDB deletion in the heartbeat response
is asynchronous, where the delete tasks are simply added to a pending deletion
cache, so it does not affect the success of the heartbeat response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
