mukund-thakur commented on code in PR #7168: URL: https://github.com/apache/hadoop/pull/7168#discussion_r1850796981
########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestElasticByteBufferPool.java: ########## @@ -0,0 +1,35 @@ +package org.apache.hadoop.io; + +import org.assertj.core.api.Assertions; +import org.junit.Test; + +import java.nio.ByteBuffer; + +public class TestElasticByteBufferPool { Review Comment: You are just testing the WeakReferencedElasticByteBufferPool here as well with just using the abstract base class. I think this is just duplicate and you can just change all the instances of base class in the TestWeakReferencedElasticByteBufferPool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org