adoroszlai commented on code in PR #7145:
URL: https://github.com/apache/hadoop/pull/7145#discussion_r1875764818
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalLogger.java:
##########
@@ -56,9 +65,8 @@ private static class Handler implements SignalHandler {
* @param signal The incoming signal
*/
@Override
- public void handle(Signal signal) {
- log.error("RECEIVED SIGNAL " + signal.getNumber() +
- ": SIG" + signal.getName());
+ public void handle(int signal) {
+ log.error("RECEIVED SIGNAL {}: SIG{}", signal, Signal.valueOf(signal));
Review Comment:
`Signal` name includes `SIG...`, so I think this would log e.g. `SIGSIGHUP`.
```suggestion
log.error("RECEIVED SIGNAL {}: {}", signal, Signal.valueOf(signal));
```
##########
hadoop-project/pom.xml:
##########
@@ -237,6 +237,7 @@
<yarnpkg.version>v1.22.5</yarnpkg.version>
<apache-ant.version>1.10.13</apache-ant.version>
<jmh.version>1.20</jmh.version>
+ <jnr.posix.version>3.1.19</jnr.posix.version>
Review Comment:
3.1.20 is now available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
