[
https://issues.apache.org/jira/browse/HADOOP-19357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904697#comment-17904697
]
ASF GitHub Bot commented on HADOOP-19357:
-----------------------------------------
anmolanmol1234 commented on code in PR #7216:
URL: https://github.com/apache/hadoop/pull/7216#discussion_r1879377311
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestExponentialRetryPolicy.java:
##########
@@ -96,6 +96,16 @@ public void testDefaultMaxIORetryCount() throws Exception {
testMaxIOConfig(abfsConfig);
}
+ @Test
+ public void testDefaultClientSideThrottling() throws Exception {
+ final Configuration configuration = new Configuration();
+ AbfsConfiguration abfsConfiguration = new AbfsConfiguration(configuration,
+ DUMMY_ACCOUNT_NAME);
+ Assume.assumeTrue(configuration.get(FS_AZURE_ENABLE_AUTOTHROTTLING) ==
null);
+ Assertions.assertThat(abfsConfiguration.isAutoThrottlingEnabled())
Review Comment:
This test will fail if someone enables throttling
> ABFS: Optimizations for Retry Handling and Throttling
> -----------------------------------------------------
>
> Key: HADOOP-19357
> URL: https://issues.apache.org/jira/browse/HADOOP-19357
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 3.4.0, 3.4.1
> Reporter: Manika Joshi
> Assignee: Manika Joshi
> Priority: Minor
> Labels: pull-request-available
>
> Given the significant improvements on the service side over the past few
> years, the current client-side retry mechanism, which enforces 5-6 minutes of
> sleep time with jitter, is now excessive. Therefore, we are realigning the
> retry and throttling logic thresholds.
> Since the service can now handle higher traffic rates, we aim to enhance
> driver performance by setting the following configurations as default:
> * {*}Client-side throttling (CST){*}: Off
> * *Client Backoff* - 500ms
> * *Max Backoff* - 25s
> * *Min Backoff* - 500ms
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
