HarshitGupta11 commented on code in PR #7197:
URL: https://github.com/apache/hadoop/pull/7197#discussion_r1888067159
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/BulkDeleteCommand.java:
##########
@@ -88,56 +116,78 @@ protected LinkedList<PathData>
expandArguments(LinkedList<String> args) throws I
return pathData;
}
+ /**
+ * Deletes the objects using the bulk delete api
+ * @param bulkDelete Bulkdelete object exposing the API
+ * @param paths list of paths to be deleted in the base path
+ * @throws IOException on error in execution of the delete command
+ */
void deleteInBatches(BulkDelete bulkDelete, List<Path> paths) throws
IOException {
Batch<Path> batches = new Batch<>(paths, pageSize);
while(batches.hasNext()) {
- bulkDelete.bulkDelete(batches.next());
+ List<Map.Entry<Path, String>> result =
bulkDelete.bulkDelete(batches.next());
Review Comment:
Added a catch clause around it and logged the error, should it fail
completely here or not, if a single batch fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
