tomscut commented on PR #7230: URL: https://github.com/apache/hadoop/pull/7230#issuecomment-2556110139
> > cc @slfan1989 > > @pan3793 Thank you for inviting me to review the code! I have no issues with this PR, but this hardcoding approach doesn't seem ideal. Is there a better solution we could consider? cc: @cxzl25 @tomscut Thanks for your comments. IMO, this is acceptable. The content related to JVM metric is rarely changed. We can also refer to `https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instru ment/binder/jvm/JvmMemory.java`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
