[ 
https://issues.apache.org/jira/browse/HADOOP-19371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907254#comment-17907254
 ] 

ASF GitHub Bot commented on HADOOP-19371:
-----------------------------------------

tomscut commented on PR #7230:
URL: https://github.com/apache/hadoop/pull/7230#issuecomment-2556110139

   > > cc @slfan1989
   > 
   > @pan3793 Thank you for inviting me to review the code! I have no issues 
with this PR, but this hardcoding approach doesn't seem ideal. Is there a 
better solution we could consider? cc: @cxzl25 @tomscut
   
   Thanks for your comments. IMO, this is acceptable. The content related to 
JVM metric is rarely changed. We can also refer to 
`https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instru
 ment/binder/jvm/JvmMemory.java`.
   




> JVM GC Metrics supports ZGC pause time and count
> ------------------------------------------------
>
>                 Key: HADOOP-19371
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19371
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: dzcxzl
>            Priority: Minor
>              Labels: pull-request-available
>
> 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles
> [https://bugs.openjdk.org/browse/JDK-8265136]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to