steveloughran commented on code in PR #7237:
URL: https://github.com/apache/hadoop/pull/7237#discussion_r1895855265
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -1560,6 +1560,11 @@ private Constants() {
*/
public static final String AWS_AUTH_CLASS_PREFIX = "com.amazonaws.auth";
+
+ public static final String INPUT_STREAM_TYPE = "fs.s3a.input.stream.type";
Review Comment:
javadocs
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/InputStreamType.java:
##########
@@ -0,0 +1,29 @@
+package org.apache.hadoop.fs.s3a;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public enum InputStreamType {
+ CLASSIC("classic"),
+ PREFETCH("prefetch"),
+ ANALYTICS("analytics");
+
+ private final String name;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(InputStreamType.class);
+
+ InputStreamType(String name) {
+ this.name = name;
+ }
+
+ public static InputStreamType fromString(String inputStreamType) {
+ for (InputStreamType value : values()) {
+ if (value.name.equalsIgnoreCase(inputStreamType)) {
+ return value;
+ }
+ }
+ LOG.warn("Unknown input stream type {}, using default classic stream.",
inputStreamType);
Review Comment:
log once at info. we aren't the AWS SDK here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
