KeeProMise commented on PR #7254: URL: https://github.com/apache/hadoop/pull/7254#issuecomment-2564989152
> @Hexiaoqiao @KeeProMise Sir, please help review this PR when you have free time, Thanks a lot. By the way, I think asyncCallCounter field is useless if this PR applied. What's your opinions. Hi, @hfutatzhanghb, thanks for your contribution. Functionally, I don't see any issues; however, in terms of implementation, I think we could manage an attribute called asyncCallCounter within each connect instance to control the maximum number of calls for that connect. This approach would eliminate the need for the asyncCallCounters map, where each remoteId corresponds to a connect object. Moreover, the connect object can be removed, but the asyncCallCounters map can only add data and cannot delete it. I also think asyncCallCounter field is useless if this PR applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
