[
https://issues.apache.org/jira/browse/HADOOP-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909409#comment-17909409
]
ASF GitHub Bot commented on HADOOP-19351:
-----------------------------------------
steveloughran commented on code in PR #7223:
URL: https://github.com/apache/hadoop/pull/7223#discussion_r1901196215
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestConstants.java:
##########
@@ -63,6 +63,11 @@ public interface S3ATestConstants {
*/
String KEY_ACL_TESTS_ENABLED = TEST_FS_S3A + "create.acl.enabled";
+ /**
+ * A property set to true if tests running in performance mode are enabled:
{@value }
+ */
+ String KEY_PERFORMANCE_TESTS_ENABLED = TEST_FS_S3A + "perf.enabled";
Review Comment:
call this "performance.enabled"; perf is a bit too terse.
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md:
##########
@@ -767,6 +771,18 @@ Tests in `ITestS3AContentEncoding` may need disabling
<value>false</value>
</property>
```
+
+### Disabling tests running in performance mode
+
+Some tests running in performance mode turn off the safety checks. They expect
breaking posix semantics.
Review Comment:
"they expect operations which break POSIX semantics to succeed"
> S3A: Add config option to skip test with performance mode
> ---------------------------------------------------------
>
> Key: HADOOP-19351
> URL: https://issues.apache.org/jira/browse/HADOOP-19351
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.4.1
> Reporter: Chung En Lee
> Assignee: Chung En Lee
> Priority: Minor
> Labels: pull-request-available
>
> For stores with posix semantics, some tests will fail in performance mode.
> Add a configuration option to skip running tests in performance mode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
