[
https://issues.apache.org/jira/browse/HADOOP-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268350#comment-13268350
]
Harsh J commented on HADOOP-8358:
---------------------------------
bq. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
Findbugs test-patch run seems to have issues with cross-module patches perhaps.
I'm able to get perfect results from it via manual per-module exec:
{code}
➜ hadoop-common-project git:(trunk) ✗ mvn findbugs:findbugs
(…)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Hadoop Annotations ......................... SUCCESS [6.237s]
[INFO] Apache Hadoop Auth ................................ SUCCESS [7.671s]
[INFO] Apache Hadoop Auth Examples ....................... SUCCESS [4.128s]
[INFO] Apache Hadoop Common .............................. SUCCESS [45.043s]
[INFO] Apache Hadoop Common Project ...................... SUCCESS [0.013s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
{code}
{code}
➜ hadoop-hdfs git:(trunk) ✗ mvn findbugs:findbugs
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Hadoop HDFS 3.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- findbugs-maven-plugin:2.3.2:findbugs (default-cli) @ hadoop-hdfs ---
[INFO] ****** FindBugsMojo execute *******
[INFO] canGenerate is true
[INFO] ****** FindBugsMojo executeFindbugs *******
[INFO] Temp File is
/Users/harshchouraria/Work/code/apache/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/findbugsTemp.xml
[INFO] Fork Value is true
[INFO] xmlOutput is false
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
{code}
(Is the build supposed to fail? Per the test-patch, that message is given when
it returns non-zero results.)
bq. -1 javadoc. The javadoc tool appears to have generated 2 warning messages.
I ran {{mvn javadoc:javadoc}} manually on common, where I did include one
javadoc change and the results indicate that the warning is from some other
change:
{code}
2 warnings
[WARNING] Javadoc Warnings
[WARNING]
/Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:334:
warning - Tag @link: missing '#': "addDeprecation(String key, String newKey)"
[WARNING]
/Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:285:
warning - Tag @link: missing '#': "addDeprecation(String key, String newKey,
[WARNING] String customMessage)"
{code}
Probably HADOOP-8172 was the one that introduced these.
Hence, the -1s are both unrelated to my moderately trivial patch.
> Config-related WARN for dfs.web.ugi can be avoided.
> ---------------------------------------------------
>
> Key: HADOOP-8358
> URL: https://issues.apache.org/jira/browse/HADOOP-8358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Attachments: HADOOP-8358.patch
>
>
> {code}
> 2012-05-04 11:55:13,367 WARN org.apache.hadoop.http.lib.StaticUserWebFilter:
> dfs.web.ugi should not be used. Instead, use hadoop.http.staticuser.user.
> {code}
> Looks easy to fix, and we should avoid using old config params that we
> ourselves deprecated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
