[ 
https://issues.apache.org/jira/browse/HADOOP-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910039#comment-17910039
 ] 

ASF GitHub Bot commented on HADOOP-19232:
-----------------------------------------

hadoop-yetus commented on PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#issuecomment-2572531842

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 21s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 36 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  22m 13s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 23s |  |  trunk passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  compile  |   0m 21s |  |  trunk passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  checkstyle  |   0m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 24s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  trunk passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  |  trunk passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  spotbugs  |   0m 43s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 24s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 20s |  |  the patch passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javac  |   0m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 16s |  |  the patch passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  javac  |   0m 16s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 14s | 
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
 |  hadoop-tools/hadoop-azure: The patch generated 87 new + 23 unchanged - 2 
fixed = 110 total (was 25)  |
   | +1 :green_heart: |  mvnsite  |   0m 18s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 17s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt)
 |  hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 
with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 generated 17 new + 11 
unchanged - 0 fixed = 28 total (was 11)  |
   | -1 :x: |  javadoc  |   0m 16s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt)
 |  
hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga
 with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga generated 17 
new + 11 unchanged - 0 fixed = 28 total (was 11)  |
   | -1 :x: |  spotbugs  |   0m 47s | 
[/new-spotbugs-hadoop-tools_hadoop-azure.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/artifact/out/new-spotbugs-hadoop-tools_hadoop-azure.html)
 |  hadoop-tools/hadoop-azure generated 10 new + 0 unchanged - 0 fixed = 10 
total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  20m  7s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 57s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 21s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  71m  0s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hadoop-tools/hadoop-azure |
   |  |  Dead store to isNamespaceEnabled rather than field with same name in 
org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.rename(Path, Path, 
TracingContext, String)  At AzureBlobFileSystemStore.java:than field with same 
name in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.rename(Path, 
Path, TracingContext, String)  At AzureBlobFileSystemStore.java:[line 1117] |
   |  |  Found reliance on default encoding in 
org.apache.hadoop.fs.azurebfs.services.AbfsBlobBlock.generateBlockId(long):in 
org.apache.hadoop.fs.azurebfs.services.AbfsBlobBlock.generateBlockId(long): 
String.getBytes()  At AbfsBlobBlock.java:[line 54] |
   |  |  Null passed for non-null parameter of flush(byte[], String, boolean, 
String, String, String, ContextEncryptionAdapter, TracingContext) in 
org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.flush(String, long, 
boolean, boolean, String, String, ContextEncryptionAdapter, TracingContext)  At 
AbfsBlobClient.java:of flush(byte[], String, boolean, String, String, String, 
ContextEncryptionAdapter, TracingContext) in 
org.apache.hadoop.fs.azurebfs.services.AbfsBlobClient.flush(String, long, 
boolean, boolean, String, String, ContextEncryptionAdapter, TracingContext)  At 
AbfsBlobClient.java:[line 872] |
   |  |  Write to static field 
org.apache.hadoop.fs.azurebfs.services.AbfsClient.isNamespaceEnabled from 
instance method 
org.apache.hadoop.fs.azurebfs.services.AbfsClient.setIsNamespaceEnabled(boolean)
  At AbfsClient.java:from instance method 
org.apache.hadoop.fs.azurebfs.services.AbfsClient.setIsNamespaceEnabled(boolean)
  At AbfsClient.java:[line 1633] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.fs.azurebfs.services.AbfsOutputStream.client; locked 50% of 
time  Unsynchronized access at AbfsOutputStream.java:50% of time  
Unsynchronized access at AbfsOutputStream.java:[line 513] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.fs.azurebfs.services.AbfsOutputStream.position; locked 71% of 
time  Unsynchronized access at AbfsOutputStream.java:71% of time  
Unsynchronized access at AbfsOutputStream.java:[line 1070] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.writeAppendBlobCurrentBufferToService()
  At AzureBlobIngressHandler.java:is not thrown in 
org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.writeAppendBlobCurrentBufferToService()
  At AzureBlobIngressHandler.java:[line 312] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.fs.azurebfs.services.AzureBlockManager.activeBlock; locked 
85% of time  Unsynchronized access at AzureBlockManager.java:85% of time  
Unsynchronized access at AzureBlockManager.java:[line 136] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.writeAppendBlobCurrentBufferToService()
  At AzureDfsToBlobIngressFallbackHandler.java:is not thrown in 
org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.writeAppendBlobCurrentBufferToService()
  At AzureDfsToBlobIngressFallbackHandler.java:[line 256] |
   |  |  Format string should use %n rather than n in 
org.apache.hadoop.fs.azurebfs.services.AzureIngressHandler.generateBlockListXml(List)
  At AzureIngressHandler.java:rather than n in 
org.apache.hadoop.fs.azurebfs.services.AzureIngressHandler.generateBlockListXml(List)
  At AzureIngressHandler.java:[line 211] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7272 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 4d4e5105ea31 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 
20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / a0164df27630f0a583ccfd28663ebc7d06270e86 |
   | Default Java | Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/testReport/ |
   | Max. process+thread count | 555 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/1/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> ABFS: [FnsOverBlob] Implementing Ingress Support with various Fallback 
> Handling
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-19232
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19232
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.0
>            Reporter: Descifrado
>            Assignee: Anmol Asrani
>            Priority: Major
>
> Scope of this task is to refactor the AbfsOutputStream class to handle the 
> ingress for DFS and Blob endpoint effectively.
> More details will be added soon.
> Perquisites for this Patch:
> 1. [HADOOP-19187] ABFS: [FnsOverBlob]Making AbfsClient Abstract for 
> supporting both DFS and Blob Endpoint - ASF JIRA (apache.org)
> 2. [HADOOP-19226] ABFS: [FnsOverBlob]Implementing Azure Rest APIs on Blob 
> Endpoint for AbfsBlobClient - ASF JIRA (apache.org)
> 3. [HADOOP-19207] ABFS: [FnsOverBlob]Response Handling of Blob Endpoint APIs 
> and Metadata APIs - ASF JIRA (apache.org)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to