anujmodi2021 commented on code in PR #7252:
URL: https://github.com/apache/hadoop/pull/7252#discussion_r1903816150
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:
##########
@@ -912,8 +913,14 @@ private void connectUsingCredentials(String accountName,
URI blobEndPoint;
if (isStorageEmulatorAccount(accountName)) {
isStorageEmulator = true;
- CloudStorageAccount account =
- CloudStorageAccount.getDevelopmentStorageAccount();
+ String storageEmulatorProxyUrl = getStorageEmulatorProxyUrl();
+ CloudStorageAccount account;
Review Comment:
Can we add a basic unit test case around this feature?
Simply check that account url is what configured and if its not configured
thenits localhost.
Anyway we will need a new test to pass yetus checks on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
