anmolanmol1234 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1912739077
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -499,21 +556,50 @@ public AbfsRestOperation breakLease(final String path,
* @param isMetadataIncompleteState was there a rename failure due to
* incomplete metadata state?
* @param isNamespaceEnabled whether namespace enabled account or not
- * @return result of rename operation
- * @throws IOException if rename operation fails.
+ *
+ * @return AbfsClientRenameResult result of rename operation indicating the
+ * AbfsRest operation, rename recovery and incomplete metadata state failure.
+ *
+ * @throws IOException failure, excluding any recovery from overload
failures.
*/
@Override
public AbfsClientRenameResult renamePath(final String source,
- final String destination,
- final String continuation,
- final TracingContext tracingContext,
- final String sourceEtag,
- final boolean isMetadataIncompleteState,
- final boolean isNamespaceEnabled) throws IOException {
- /**
- * TODO: [FnsOverBlob] To be implemented as part of rename-delete over
blob endpoint work. <a
href="https://issues.apache.org/jira/browse/HADOOP-19233";>HADOOP-19233</a>.
- */
- throw new NotImplementedException("Rename operation on Blob endpoint yet
to be implemented.");
+ final String destination,
+ final String continuation,
+ final TracingContext tracingContext,
+ String sourceEtag,
+ boolean isMetadataIncompleteState,
+ boolean isNamespaceEnabled)
+ throws IOException {
+ BlobRenameHandler blobRenameHandler = getBlobRenameHandler(source,
+ destination, sourceEtag, isAtomicRenameKey(source), tracingContext
+ );
+ incrementAbfsRenamePath();
+ if (blobRenameHandler.execute()) {
+ final AbfsUriQueryBuilder abfsUriQueryBuilder =
createDefaultUriQueryBuilder();
+ final URL url = createRequestUrl(destination,
abfsUriQueryBuilder.toString());
+ final List<AbfsHttpHeader> requestHeaders = createDefaultHeaders();
+ final AbfsRestOperation successOp = getAbfsRestOperation(
+ AbfsRestOperationType.RenamePath, HTTP_METHOD_PUT,
+ url, requestHeaders);
+ successOp.hardSetResult(HttpURLConnection.HTTP_OK);
+ return new AbfsClientRenameResult(successOp, true, false);
+ } else {
+ throw new AbfsRestOperationException(HTTP_INTERNAL_ERROR,
+ AzureServiceErrorCode.UNKNOWN.getErrorCode(),
+ "FNS-Blob Rename was not successfull",
Review Comment:
Should add path or file name as well where rename failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
