Hexiaoqiao commented on code in PR #7019:
URL: https://github.com/apache/hadoop/pull/7019#discussion_r1916609008


##########
dev-support/Jenkinsfile:
##########
@@ -71,7 +71,7 @@ pipeline {
                     checkout([
                         $class: 'GitSCM',
                         branches: [[name: "${env.YETUS_VERSION}"]],
-                        userRemoteConfigs: [[ url: 
'https://github.com/apache/yetus.git']]]
+                        userRemoteConfigs: [[ url: 
'https://github.com/ayushtkn/yetus.git']]]

Review Comment:
   It is better to link Hadoop repo rather than Ayushtkn's personal repo.



##########
LICENSE-binary:
##########
@@ -498,12 +498,16 @@ org.slf4j:slf4j-reload4j:1.7.36
 CDDL 1.1 + GPLv2 with classpath exception
 -----------------------------------------
 
-com.github.pjfanning:jersey-json:1.22.0
-com.sun.jersey:jersey-client:1.19.4
-com.sun.jersey:jersey-core:1.19.4
-com.sun.jersey:jersey-guice:1.19.4
-com.sun.jersey:jersey-server:1.19.4
-com.sun.jersey:jersey-servlet:1.19.4
+org.glassfish.jersey.core:jersey-common:2.46

Review Comment:
   It is OK to located this package to Apache License or MIT if it is dual 
licensed IMO, if we could not make sure, maybe refer Spark 
https://github.com/apache/spark/blob/master/LICENSE-binary and write it under 
Apache License will not be wrong. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to