cnauroth commented on code in PR #5044:
URL: https://github.com/apache/hadoop/pull/5044#discussion_r1917433627
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java:
##########
@@ -122,6 +123,45 @@ Double getUtilization(DatanodeStorageReport r, final
StorageType t) {
}
}
+ /**
+ * Cluster is balanced if each node is balanced. Unlike {@link Node},
+ * The policy take into account non-DFS used spaces.
+ * <p>
+ * Actual DFS capacity (capacity - non-DFS used) is calculated by
Review Comment:
Intuitively, I would have expected the code to calculate this as
`s.getCapacity() - s.getNonDfsUsed()`. Is there some reason this calculation
doesn't work and instead we need to infer it as (DFS used + remaining)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
