ashutoshcipher commented on code in PR #7291:
URL: https://github.com/apache/hadoop/pull/7291#discussion_r1917772079
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java:
##########
@@ -67,39 +75,194 @@ public void testDisplayForAvroFiles() throws Exception {
assertEquals(expectedOutput, output);
}
+ @Test
Review Comment:
We might want to Test a scenario where the stream is read in very small
chunks (e.g., 1 or 2 bytes at a time) in the multi-byte read() method. This can
confirm no edge cases remain where you might loop incorrectly or miss a final
newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
