[ https://issues.apache.org/jira/browse/HADOOP-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913708#comment-17913708 ]
ASF GitHub Bot commented on HADOOP-19232: ----------------------------------------- hadoop-yetus commented on PR #7272: URL: https://github.com/apache/hadoop/pull/7272#issuecomment-2595497781 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 21m 10s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +0 :ok: | markdownlint | 0m 1s | | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 32 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 35m 20s | | trunk passed | | +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 | | +1 :green_heart: | compile | 0m 35s | | trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga | | +1 :green_heart: | checkstyle | 0m 32s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 40s | | trunk passed | | +1 :green_heart: | javadoc | 0m 40s | | trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 | | +1 :green_heart: | javadoc | 0m 33s | | trunk passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga | | +1 :green_heart: | spotbugs | 1m 6s | | trunk passed | | +1 :green_heart: | shadedclient | 35m 2s | | branch has no errors when building and testing our client artifacts. | | -0 :warning: | patch | 35m 23s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 29s | | the patch passed | | +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 | | +1 :green_heart: | javac | 0m 30s | | the patch passed | | +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga | | +1 :green_heart: | javac | 0m 27s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 20s | [/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt) | hadoop-tools/hadoop-azure: The patch generated 16 new + 22 unchanged - 1 fixed = 38 total (was 23) | | +1 :green_heart: | mvnsite | 0m 30s | | the patch passed | | -1 :x: | javadoc | 0m 27s | [/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt) | hadoop-tools_hadoop-azure-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11) | | -1 :x: | javadoc | 0m 26s | [/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt) | hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11) | | -1 :x: | spotbugs | 1m 8s | [/new-spotbugs-hadoop-tools_hadoop-azure.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/artifact/out/new-spotbugs-hadoop-tools_hadoop-azure.html) | hadoop-tools/hadoop-azure generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) | | +1 :green_heart: | shadedclient | 34m 8s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 22s | | hadoop-azure in the patch passed. | | +1 :green_heart: | asflicense | 0m 36s | | The patch does not generate ASF License warnings. | | | | 139m 13s | | | | Reason | Tests | |-------:|:------| | SpotBugs | module:hadoop-tools/hadoop-azure | | | Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteAppendBlobWrite(String, DataBlocks$BlockUploadData, AbfsBlock, AppendRequestParameters, TracingContext) Redundant null check at AzureBlobIngressHandler.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteAppendBlobWrite(String, DataBlocks$BlockUploadData, AbfsBlock, AppendRequestParameters, TracingContext) Redundant null check at AzureBlobIngressHandler.java:[line 227] | | | Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteFlush(long, boolean, boolean, String, TracingContext) Redundant null check at AzureBlobIngressHandler.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteFlush(long, boolean, boolean, String, TracingContext) Redundant null check at AzureBlobIngressHandler.java:[line 190] | | | Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteWrite(AbfsBlock, DataBlocks$BlockUploadData, AppendRequestParameters, TracingContext) Redundant null check at AzureBlobIngressHandler.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureBlobIngressHandler.remoteWrite(AbfsBlock, DataBlocks$BlockUploadData, AppendRequestParameters, TracingContext) Redundant null check at AzureBlobIngressHandler.java:[line 140] | | | Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.remoteFlush(long, boolean, boolean, String, TracingContext) Redundant null check at AzureDfsToBlobIngressFallbackHandler.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.remoteFlush(long, boolean, boolean, String, TracingContext) Redundant null check at AzureDfsToBlobIngressFallbackHandler.java:[line 163] | | | Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.remoteWrite(AbfsBlock, DataBlocks$BlockUploadData, AppendRequestParameters, TracingContext) Redundant null check at AzureDfsToBlobIngressFallbackHandler.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AzureDfsToBlobIngressFallbackHandler.remoteWrite(AbfsBlock, DataBlocks$BlockUploadData, AppendRequestParameters, TracingContext) Redundant null check at AzureDfsToBlobIngressFallbackHandler.java:[line 124] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/7272 | | JIRA Issue | HADOOP-19232 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint | | uname | Linux 3455ead6dd56 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 1df66bb973704e4c205e6079fe43bea9b2f8fb31 | | Default Java | Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/testReport/ | | Max. process+thread count | 704 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7272/12/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > ABFS: [FnsOverBlob] Implementing Ingress Support with various Fallback > Handling > ------------------------------------------------------------------------------- > > Key: HADOOP-19232 > URL: https://issues.apache.org/jira/browse/HADOOP-19232 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.4.0 > Reporter: Anuj Modi > Assignee: Anmol Asrani > Priority: Major > Labels: pull-request-available > > Scope of this task is to refactor the AbfsOutputStream class to handle the > ingress for DFS and Blob endpoint effectively. > More details will be added soon. > Perquisites for this Patch: > 1. [HADOOP-19187] ABFS: [FnsOverBlob]Making AbfsClient Abstract for > supporting both DFS and Blob Endpoint - ASF JIRA (apache.org) > 2. [HADOOP-19226] ABFS: [FnsOverBlob]Implementing Azure Rest APIs on Blob > Endpoint for AbfsBlobClient - ASF JIRA (apache.org) > 3. [HADOOP-19207] ABFS: [FnsOverBlob]Response Handling of Blob Endpoint APIs > and Metadata APIs - ASF JIRA (apache.org) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org