KeeProMise commented on code in PR #7292:
URL: https://github.com/apache/hadoop/pull/7292#discussion_r1918620312
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/protocolPB/AsyncRpcProtocolPBUtil.java:
##########
@@ -87,6 +89,7 @@ public static <T, R> R asyncIpcClient(
// transfer thread local context to worker threads of executor.
ThreadLocalContext threadLocalContext = new ThreadLocalContext();
asyncCompleteWith(responseFuture.handleAsync((result, e) -> {
+ FederationRPCMetrics.ASYNC_RESPONDER_START_TIME.set(Time.monotonicNow());
Review Comment:
Hi @hfutatzhanghb If thread local variables are used, it is recommended to
use ThreadLocalContext, refer to startUpTime and proxyOpTime; because the
response of a request may be processed by async responder or async handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
