mukund-thakur commented on code in PR #7197:
URL: https://github.com/apache/hadoop/pull/7197#discussion_r1924459210
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/BulkDeleteCommand.java:
##########
@@ -134,10 +138,14 @@ void deleteInBatches(BulkDelete bulkDelete, List<Path>
paths) throws IOException
while (batches.hasNext()) {
try {
List<Map.Entry<Path, String>> result =
bulkDelete.bulkDelete(batches.next());
- LOG.debug("Deleted Result:{}", result.toString());
+ if(!result.isEmpty()) {
+ LOG.warn("Number of failed deletions:{}", result.size());
+ for(Map.Entry<Path, String> singleResult: result) {
+ LOG.info("{}: {}", singleResult.getKey(), singleResult.getValue());
+ }
+ }
} catch (IllegalArgumentException e) {
- LOG.error("Caught exception while deleting", e);
- throw new IOException(e);
+ throw new IOException("Exception while deleting: ", e);
Review Comment:
Assuming e will in turn print path as that was the only pending comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
