[
https://issues.apache.org/jira/browse/HADOOP-19254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915850#comment-17915850
]
ASF GitHub Bot commented on HADOOP-19254:
-----------------------------------------
mukund-thakur commented on code in PR #7197:
URL: https://github.com/apache/hadoop/pull/7197#discussion_r1924459210
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/BulkDeleteCommand.java:
##########
@@ -134,10 +138,14 @@ void deleteInBatches(BulkDelete bulkDelete, List<Path>
paths) throws IOException
while (batches.hasNext()) {
try {
List<Map.Entry<Path, String>> result =
bulkDelete.bulkDelete(batches.next());
- LOG.debug("Deleted Result:{}", result.toString());
+ if(!result.isEmpty()) {
+ LOG.warn("Number of failed deletions:{}", result.size());
+ for(Map.Entry<Path, String> singleResult: result) {
+ LOG.info("{}: {}", singleResult.getKey(), singleResult.getValue());
+ }
+ }
} catch (IllegalArgumentException e) {
- LOG.error("Caught exception while deleting", e);
- throw new IOException(e);
+ throw new IOException("Exception while deleting: ", e);
Review Comment:
Assuming e will in turn print path as that was the only pending comment!
> Implement bulk delete command as hadoop fs command operation
> -------------------------------------------------------------
>
> Key: HADOOP-19254
> URL: https://issues.apache.org/jira/browse/HADOOP-19254
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.4.1
> Reporter: Mukund Thakur
> Assignee: Harshit Gupta
> Priority: Major
> Labels: pull-request-available
>
> {code}
> hadoop fs -bulkdelete <base-url> <file>
> {code}
> Key uses
> * QE: Testing from python and other scripting languages
> * cluster maintenance: actual bulk deletion operations from the store
> one thought there: we MUST qualify paths with / elements: if a passed in path
> ends in /, it means "delete a marker", not "delete a dir"'. and if it doesn't
> have one then it's an object.. This makes it possible to be used to delete
> surplus markers or where there is a file above another file...cloudstore
> listobjects finds this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
