slfan1989 commented on PR #7337: URL: https://github.com/apache/hadoop/pull/7337#issuecomment-2626042603
> Wow, this is awesome @slfan1989 and @zhtttylz ! Here are my opinions on how to proceed. > > > 1. **Import Optimization** > > ... > > 2. **Import * Optimization** > > ... > > 3. **Addressing Checkstyle Issues, Incomplete JavaDocs, and Typos** > > ... > > I'd like to suggest that in this phase, we stick to a minimal effort of making a straight translation to JUnit 5 in the interest of completing a JDK 17 release as soon as possible. These are going to be large pull requests to review, even after we break them into sub-tasks. It will take longer to code review if we start including other unrelated improvements. > > All of these proposals are good code quality improvements though. We can pick them up as future work after completing the JUnit 5 migration and after the JDK 17 release. > > I've also heard there's a desire to go toward AssertJ. If so, then that might change the plan on points 1 and 2. > > > 4. **Improvements for Large Modules** > > ... > > Due to these dependencies, we will not upgrade this abstract class for now. Instead, we will parallelly upgrade the parts of these three modules(`hadoop-aws`, `hadoop-common`, and `hadoop-aliyun`) that have no dependencies. Once the other parts are upgraded, we will come back to upgrade the unit tests with dependencies. > > I agree with your strategy here. It sounds like this is the best way to manage pull request size and code review process. @cnauroth Thank you for your message! I agree with your point of view. We will only make the necessary changes and will not adjust other improvements for now. Once the JUnit 5 upgrade is complete, we will proceed with further optimizations. Here are the improvement principles I've summarized: 1. Focus on making the necessary changes to ensure the upgrade is completed smoothly. 2. If the Yetus report highlights Checkstyle issues or other problems, we will address them to achieve a successful compile result. 3. Break down large modules into smaller PRs to make the code review process more efficient and user-friendly. cc: @steveloughran @ayushtkn @Hexiaoqiao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
