anujmodi2021 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1937087835
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -1155,9 +1169,10 @@ public void delete(final Path path, final boolean
recursive,
do {
try (AbfsPerfInfo perfInfo = startTracking("delete", "deletePath")) {
AbfsRestOperation op = getClient().deletePath(relativePath, recursive,
- continuation, tracingContext,
getIsNamespaceEnabled(tracingContext));
+ continuation, tracingContext);
perfInfo.registerResult(op.getResult());
- continuation =
op.getResult().getResponseHeader(HttpHeaderConfigurations.X_MS_CONTINUATION);
+ continuation = op.getResult()
Review Comment:
Avoid diffs
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -1144,9 +1158,9 @@ public void delete(final Path path, final boolean
recursive,
boolean shouldContinue = true;
LOG.debug("delete filesystem: {} path: {} recursive: {}",
- getClient().getFileSystem(),
- path,
- String.valueOf(recursive));
+ getClient().getFileSystem(),
Review Comment:
Avoid diffs
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -673,7 +694,7 @@ public OutputStream createFile(final Path path,
}
final ContextEncryptionAdapter contextEncryptionAdapter;
- if (createClient.getEncryptionType() ==
EncryptionType.ENCRYPTION_CONTEXT) {
+ if (getClient().getEncryptionType() ==
EncryptionType.ENCRYPTION_CONTEXT) {
Review Comment:
Why are we changing this.
This seems wrong. Right @anmolanmol1234
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -1114,15 +1129,14 @@ public boolean rename(final Path source,
do {
try (AbfsPerfInfo perfInfo = startTracking("rename", "renamePath")) {
- boolean isNamespaceEnabled = getIsNamespaceEnabled(tracingContext);
final AbfsClientRenameResult abfsClientRenameResult =
getClient().renamePath(sourceRelativePath, destinationRelativePath,
- continuation, tracingContext, sourceEtag, false,
- isNamespaceEnabled);
+ continuation, tracingContext, sourceEtag, false);
AbfsRestOperation op = abfsClientRenameResult.getOp();
perfInfo.registerResult(op.getResult());
- continuation =
op.getResult().getResponseHeader(HttpHeaderConfigurations.X_MS_CONTINUATION);
+ continuation = op.getResult()
Review Comment:
Avoid diffs
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1694,16 +1976,24 @@ private boolean isNonEmptyListing(String path,
* @return True if empty results without continuation token.
*/
private boolean isEmptyListResults(AbfsHttpOperation result) {
Review Comment:
Why diffs in this method, please avoid unneceessary diffs.
I agree that they don't break anything but the PR is already big. It should
not touch the code it is not supposed to do.
For general improvements please raise another Jira and PR.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -18,6 +18,7 @@
package org.apache.hadoop.fs.azurebfs;
+import javax.annotation.Nullable;
Review Comment:
Import ordering looks wrong. Causing unneccessary diff as well.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -42,25 +42,42 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
+import org.slf4j.Logger;
Review Comment:
Thanks for fixing import ordering in this classs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
