anujmodi2021 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1939027360
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -530,45 +541,31 @@ public boolean rename(final Path src, final Path dst)
throws IOException {
return tryGetFileStatus(qualifiedSrcPath, tracingContext) != null;
}
- FileStatus dstFileStatus = null;
+ FileStatus dstFileStatus = tryGetFileStatus(qualifiedDstPath,
tracingContext);
Review Comment:
We are changing a long existing code here, lets try to make sure any corner
cases are not ignored.
All the tests should run, if you think any scenario is missed by tests
please add it.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -203,7 +203,7 @@ private AbfsClient(final URL baseUrl,
if (encryptionContextProvider != null) {
this.encryptionContextProvider = encryptionContextProvider;
- xMsVersion = ApiVersion.APR_10_2021; // will be default once server
change deployed
+ xMsVersion = ApiVersion.AUG_03_2023; // will be default once server
change deployed
Review Comment:
Nit: Add a comment why this version upgrade is needed.
cc: @anmolanmol1234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
