anmolanmol1234 commented on code in PR #7344:
URL: https://github.com/apache/hadoop/pull/7344#discussion_r1939256715
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFileStatus.java:
##########
@@ -162,6 +175,102 @@ public void testFileStatusOnRoot() throws IOException {
// Assert that passing absolute root path without "/" works
testPathStr = testPathStr.substring(0, testPathStr.length() - 1);
validateStatus(fs, new Path(testPathStr), true);
+ }
+
+ /**
+ * Test to verify fs.getFileStatus() works as expected on explicit paths as
expected.
+ * Explicit path can exist as a directory as well as a file.
+ * @throws IOException if test fails
+ */
+ @Test
+ public void testFileStatusOnExplicitPath() throws Exception {
+ AzureBlobFileSystem fs = getFileSystem();
+ Path explicitDirPath = path("explicitDir");
+ Path filePath = new Path(explicitDirPath, "explicitFile");
+ Path nonExistingPath = new Path(explicitDirPath, "nonExistingFile");
+
+ fs.mkdirs(explicitDirPath);
+ fs.create(filePath).close();
+
+ // Test File Status on explicit dir path.
+ FileStatus fileStatus = fs.getFileStatus(explicitDirPath);
+ verifyFileStatus(fileStatus, true);
+
+ // Test File Status on file with explicit parent.
+ fileStatus = fs.getFileStatus(filePath);
+ verifyFileStatus(fileStatus, false);
+
+ // Test File Status non-existing file with explicit parent.
+ FileNotFoundException ex = intercept(FileNotFoundException.class, () -> {
+ fs.getFileStatus(nonExistingPath);
+ });
+ verifyFileNotFound(ex, nonExistingPath.getName());
+ }
+
+ /**
+ * Test to verify fs.getFileStatus() works as expected on implicit paths as
expected.
+ * Implicit path can exist as a directory only in HNS-Disabled Accounts.
+ * @throws Exception
+ */
+ @Test
+ public void testFileStatusOnImplicitPath() throws Exception {
+ AzureBlobFileSystem fs = getFileSystem();
+ Path filePath = path("implicitDir/fileWithImplicitParent");
+ Path implicitDir = filePath.getParent();
+ Path nonExistingPath = new Path(implicitDir, "nonExistingFile");
+
+ createAzCopyFile(filePath);
+
+ // Test File Status on implicit dir parent.
+ FileStatus fileStatus = fs.getFileStatus(implicitDir);
+ verifyFileStatus(fileStatus, true);
+
+ // Test File Status on file with implicit parent.
+ fileStatus = fs.getFileStatus(filePath);
+ verifyFileStatus(fileStatus, false);
+
+ // Test File Status on non-existing file with implicit parent.
+ FileNotFoundException ex = intercept(FileNotFoundException.class, () -> {
+ fs.getFileStatus(nonExistingPath);
+ });
+ verifyFileNotFound(ex, nonExistingPath.getName());
+ }
+
+ /**
+ * Test to verify fs.getFileStatus() need to internally call listStatus on
path.
+ * @throws Exception if test fails
+ */
+ @Test
+ public void testListStatusIsCalledForImplicitPathOnBlobEndpoint() throws
Exception {
+ assumeBlobServiceType();
+ AzureBlobFileSystem fs = Mockito.spy(getFileSystem());
+ AzureBlobFileSystemStore store = Mockito.spy(fs.getAbfsStore());
+ Mockito.doReturn(store).when(fs).getAbfsStore();
+ AbfsBlobClient abfsClient =
Mockito.spy(store.getClientHandler().getBlobClient());
+ Mockito.doReturn(abfsClient).when(store).getClient();
+
+ Path implicitPath = path("implicitDir");
+ createAzCopyFolder(implicitPath);
+
+ fs.getFileStatus(implicitPath);
+
+ Mockito.verify(abfsClient, Mockito.times(1)).getPathStatus(any(),
eq(false), any(), any());
+ Mockito.verify(abfsClient, Mockito.times(1)).listPath(any(), eq(false),
eq(1), any(), any(), eq(false));
+ }
+
+ private void verifyFileStatus(FileStatus fileStatus, boolean isDir) {
Review Comment:
javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
