[ 
https://issues.apache.org/jira/browse/HADOOP-19443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923269#comment-17923269
 ] 

ASF GitHub Bot commented on HADOOP-19443:
-----------------------------------------

anmolanmol1234 commented on code in PR #7344:
URL: https://github.com/apache/hadoop/pull/7344#discussion_r1939267774


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClientHandler.java:
##########
@@ -42,8 +42,15 @@ public ITestAbfsClientHandler() throws Exception{
   public void testAbfsClientHandlerInitialization() throws Exception {
     AzureBlobFileSystem fs = getFileSystem();
     AbfsClientHandler clientHandler = fs.getAbfsStore().getClientHandler();
-    
Assertions.assertThat(clientHandler.getClient()).isInstanceOf(AbfsDfsClient.class);
+    if (getAbfsServiceType() == AbfsServiceType.DFS) {
+      
Assertions.assertThat(clientHandler.getClient()).isInstanceOf(AbfsDfsClient.class);
+      
Assertions.assertThat(clientHandler.getIngressClient()).isInstanceOf(AbfsDfsClient.class);

Review Comment:
   This will fail for the case when service type is DFS but ingress is 
configured for blob





> ABFS: [FnsOverBlob] Update Test Scripts to Run Tests with Blob Endpoint
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-19443
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19443
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.1
>            Reporter: Anuj Modi
>            Priority: Major
>              Labels: pull-request-available
>
> Following Cobination of test Suites will run as a part of CI after blob 
> endpoint support has been added.
> HNS-OAuth-DFS
> HNS-SharedKey-DFS
> NonHNS-SharedKey-DFS
> AppendBlob-HNS-OAuth-DFS
> NonHNS-SharedKey-Blob
> NonHNS-OAuth-DFS
> NonHNS-OAuth-Blob
> AppendBlob-NonHNS-OAuth-Blob
> HNS-Oauth-DFS-IngressBlob
> NonHNS-Oauth-DFS-IngressBlob



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to