slfan1989 commented on PR #7339: URL: https://github.com/apache/hadoop/pull/7339#issuecomment-2631295289
> Hi @slfan1989 ! > > I haven't reviewed the whole thing, but I have some general questions about the process, similar to discussion in #7337 . It seems there are several changes that aren't directly related to JUnit 5 migration. In #7337, I was in favor of an approach of a straight port to JUnit 5, with any other code quality improvements to be done later. I flagged just a few examples of what I'm talking about in line-level comments. > > Are these unrelated changes something that is also being applied by the automated tool, or are these manual coding chnages done after running the tool? > > Pre-submit also reports new Checkstyle warnings. I'd be willing to let that slide in order to get this conversion done more quickly, but I'm curious if other reviewers disagree. Thank you very much for your comment! Regarding the migration standard from JUnit4 to JUnit5, we have reached a consensus to make changes only when necessary. Currently, our conversion tool cannot automatically fix Checkstyle issues, so these need to be addressed manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
