cnauroth commented on code in PR #7345:
URL: https://github.com/apache/hadoop/pull/7345#discussion_r1940066634
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestSchedConfCLI.java:
##########
@@ -154,7 +155,8 @@ private static void setupQueueConfiguration(
config.setMaximumCapacity(a, 100f);
}
- private void cleanUp() throws Exception {
+ @After
Review Comment:
Since this is `@After` now, it would end up getting triggered twice for
methods that directly invoke it: `testGetSchedulerConf` and
`testFormatSchedulerConf`. Can you please remove those two direct calls?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java:
##########
@@ -541,4 +541,6 @@ public static ContainerId createContainerId(int cId, int
aId) {
ContainerId.newContainerId(appAttemptId, cId);
return containerId;
}
+
Review Comment:
Revert this file since the changes are a no-op?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java:
##########
@@ -560,13 +560,17 @@ public void testAMRMClientMatchStorage() throws
YarnException, IOException {
}
}
- assertEquals(2, allocatedContainerCount);
+ assertTrue(allocatedContainerCount <= 2);
Review Comment:
For these changed/commented-out assertions, I would have expected them to
pass. Do you think the problem is more like a race condition with the
assertions running before the state has settled? If so, would
`GenericTestUtils#waitFor` be helpful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
