cnauroth commented on code in PR #7348:
URL: https://github.com/apache/hadoop/pull/7348#discussion_r1941957703


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java:
##########
@@ -1200,9 +1197,7 @@ void setClosed() {
 
   @Override
   protected synchronized void closeImpl() throws IOException {
-    boolean recoverLeaseOnCloseException = dfsClient.getConfiguration()
-        .getBoolean(RECOVER_LEASE_ON_CLOSE_EXCEPTION_KEY,
-            RECOVER_LEASE_ON_CLOSE_EXCEPTION_DEFAULT);
+    boolean recoverLeaseOnCloseException = 
dfsClient.getConfiguration().getRecoverLeaseOnCloseException();

Review Comment:
   Thank you for the patch, @Abhey . Pre-submit checks show this line failing 
to compile. I think you'll need to change to `dfsClient.getConf()` so that it 
fetches the `DfsClientConf` instead of `Configuration`, and then it can call 
your new method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to