[ https://issues.apache.org/jira/browse/HADOOP-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924987#comment-17924987 ]
ASF GitHub Bot commented on HADOOP-19400: ----------------------------------------- cnauroth commented on PR #7367: URL: https://github.com/apache/hadoop/pull/7367#issuecomment-2643686251 Hi @steveloughran ! This is the follow-up you requested for more specification/test coverage of input stream reads. I've confirmed this is passing on local, HDFS and S3A (GCS as the back-end). I can't easily check the others unfortunately. > Expand specification and contract test coverage for InputStream reads. > ---------------------------------------------------------------------- > > Key: HADOOP-19400 > URL: https://issues.apache.org/jira/browse/HADOOP-19400 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation, fs, test > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Major > Labels: pull-request-available > > This issue is a spin-off from HADOOP-19389, specifically [this code review > discussion|https://github.com/apache/hadoop/pull/7291#discussion_r1920495312]. > We can enhance the FS specification and contract tests to cover expected > semantics of the {{InputStream}} single-byte and multi-byte read methods: > * Multi-byte read should validate the arguments passed to it, according to > the pattern established in the JDK base {{InputStream}} class. > * You should get the same bytes whether going through single-byte or > multi-byte read. > * It is legal to mix calls to single-byte and multi-byte read, and this > should also yield the same bytes. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org