[ https://issues.apache.org/jira/browse/HADOOP-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271540#comment-13271540 ]
Suresh Srinivas commented on HADOOP-8372: ----------------------------------------- I was concerned about performance implication of this change. However, in sun jdk, IPAddressUtil#isIPv4LiteralAddress() is called, which is doing more complete check for ip address before doing a look up. Please fix the tests. While at it, please indent the the code in the test correctly. Also, optionaly, you reduce a line by {{ return InetAddress.getByName(name).getHostAddress(); }} > normalizeHostName() in NetUtils is not working properly in resolving a > hostname start with numeric character > ------------------------------------------------------------------------------------------------------------ > > Key: HADOOP-8372 > URL: https://issues.apache.org/jira/browse/HADOOP-8372 > Project: Hadoop Common > Issue Type: Bug > Components: io, util > Affects Versions: 1.0.0, 0.23.0 > Reporter: Junping Du > Assignee: Junping Du > Attachments: HADOOP-8372.patch > > > A valid host name can start with numeric value (You can refer RFC952, RFC1123 > or http://www.zytrax.com/books/dns/apa/names.html), so it is possible in a > production environment, user name their hadoop nodes as: 1hosta, 2hostb, etc. > But normalizeHostName() will recognise this hostname as IP address and return > directly rather than resolving the real IP address. These nodes will be > failed to get correct network topology if topology script/TableMapping only > contains their IPs (without hostname). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira