slfan1989 commented on code in PR #7363:
URL: https://github.com/apache/hadoop/pull/7363#discussion_r1947556620
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##########
@@ -250,6 +250,20 @@ protected Path methodPath() throws IOException {
return path(methodName.getMethodName());
}
+ /**
+ * Get a path whose name ends with the name of this method.
+ *
+ * This is a temporary requirement for upgrading from JUnit 4 to JUnit 5,
+ * and can be deleted later.
+ *
+ * @param name name of this method.
+ * @return a path implicitly unique amongst all methods in this class
+ * @throws IOException IO problems
+ */
+ protected Path methodPath(String name) throws IOException {
Review Comment:
Thank you for your comment! I have removed the class in the latest code
submission. Initially, I planned to add this method to `hadoop-common` to
upgrade all unit tests in the `hadoop-mapreduce-client-core` module. However, I
found that the test methods in other modules inherit from the test methods of
the `hadoop-mapreduce-client-core` module, so I temporarily rolled back some
changes. Unfortunately, I forgot to remove the class. I will complete the
dependent test upgrades in `mapreduce-client-core` Part2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
