cnauroth commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1948232650
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestWasbRemoteCallHelper.java:
##########
@@ -434,10 +431,6 @@ class MatchesPattern extends TypeSafeMatcher<String> {
}
}
- expectedEx.expectMessage(new MatchesPattern(
Review Comment:
I have seen the conversions to `assertThrows`. Those all look good.
Perhaps what I find confusing is that the `setupExpectations()` method now
seems to be a no-op. It seems to define a custom matcher class, but then never
use it. Should `setupExpectations()` be removed, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
