KeeProMise commented on PR #7308: URL: https://github.com/apache/hadoop/pull/7308#issuecomment-2647792517
> I think sub PRs had already been reviewed, no need to review details again. Just leave some high level comments here > > * 3 child tasks are under ARR, 2 were merged to trunk([HADOOP-19362](https://issues.apache.org/jira/browse/HADOOP-19362), [HADOOP-19361](https://issues.apache.org/jira/browse/HADOOP-19361)) and [HADOOP-19235](https://issues.apache.org/jira/browse/HADOOP-19235) was merged to the feature branch, why did it, and not merge common changes to trunk? > * need to test this feature and then give feedback here. Hi @ferhui Actually, this PR [HADOOP-19235](https://issues.apache.org/jira/browse/HADOOP-19235) could have been directly merged into the trunk. Initially, it was intended as a subtask for ARR, which is why it was merged into the [HDFS-17531](https://issues.apache.org/jira/browse/HDFS-17531) branch. @hfutatzhanghb has contributed a test document for the feature: [Async Router RPC: single nameservice performance testing report](https://docs.google.com/document/d/1meHOCvhm3XRHlIMwvKFidfUSjveTJrb8yAMasrM_HrY/edit?tab=t.0#heading=h.du0zlo2k5sb1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
