anujmodi2021 commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1950323726
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestWasbUriAndConfiguration.java:
##########
@@ -659,7 +655,7 @@ public void testCanonicalServiceName() throws Exception {
conf.setBoolean(RETURN_URI_AS_CANONICAL_SERVICE_NAME_PROPERTY_NAME,
true);
FileSystem fs1 = FileSystem.newInstance(defaultUri, conf);
- Assert.assertEquals("getCanonicalServiceName() should return URI",
+ assertEquals("getCanonicalServiceName() should return URI",
Review Comment:
Need to fix the parameter order as per new format.
This will fix this failing test
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:
##########
@@ -81,8 +81,8 @@ public class ITestAzureHugeFiles extends
AbstractAzureScaleTest {
private Path testPath;
@Override
Review Comment:
Do we need @BeforeEach here?
I think setup is not called before test method leading to failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
