ferdelyi commented on code in PR #7324:
URL: https://github.com/apache/hadoop/pull/7324#discussion_r1950853472


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/components/yarn-queue-partition-capacity-labels.hbs:
##########
@@ -16,59 +16,255 @@
  * limitations under the License.
 }}
 
-<div class="top-1">
-  <span class="yarn-label primary">
-    <span class="label-key">absolute used</span>
+<h4>Queue Status for Partition</h4>
+{{!
+/scheduler/schedulerInfo/queues/queue[1]/resources/resourceUsagesByPartition[2]/used/resourceInformations/resourceInformation[1]/name[text()='memory-mb']
+/scheduler/schedulerInfo/queues/queue[1]/resources/resourceUsagesByPartition[2]/used/resourceInformations/resourceInformation[1]/value/text('2048')
+/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition/usedCapacity[text()='37.883835']
+}}
+<ul>
+  <li class="queues-list">
+    <span class="label-key" title=" Aka. 'Used Resources': is the total of the 
resources consumed within the queue for the given partition <memory MB, vCores, 
%>.
+    The percentage value calculated differently for the 
DefaultResourceCalculator and for the DominantResourceCalculator."><b>used 
capacity:</b></span>
+    <span class="label-value"><b>{{data.usedCapacity}}%</b></span>
+    <span class="label-value"><ul>{{#each 
data.used.resourceInformations.resourceInformation as | 
resource|}}<li>{{resource.name}}: {{resource.value}}</li>{{/each}}</ul></span>
+  </li>
+
+
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Used Capacity: percentage 
referring to the used memory from the total available memory for the 
partition">absolute used:</span>
     <span class="label-value">{{data.absoluteUsedCapacity}}%</span>
-  </span>
-  <span class="yarn-label primary">
-    <span class="label-key">absolute capacity</span>
+  </li>
+
+  {{!
+  
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition[2]/absoluteCapacity[text()='85.44922']
+  }}
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Configured Capacity: percentage 
referring to the configured memory from the total available memory for the 
partition. This value  will be different from the configured capacity only when 
the parent queue is not the root queue.">absolute configured capacity:</span>
     <span class="label-value">{{data.absoluteCapacity}}%</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">absolute max capacity</span>
+  </li>
+  {{!
+  /scheduler/schedulerInfo/queues/queue[2]/absoluteMaxCapacity[text()='100.0']
+  }}
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Configured Max Capacity: 
percentage referring to the configured maximum memory from the total available 
memory for the partition. This value will be different from the configured max 
capacity only when the parent queue is not the root queue.">absolute configured 
max capacity:</span>
     <span class="label-value">{{data.absoluteMaxCapacity}}%</span>
-  </span>
-</div>
-{{#if data.isWeightMode}}
-<div class="top-1">
-  <span class="yarn-label secondary">
-    <span class="label-key">weight</span>
-    <span class="label-value">{{data.weight}}</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">normalized weight</span>
-    <span class="label-value">{{data.normalizedWeight}}</span>
-  </span>
-</div>
-{{else}}
-<div class="top-1">
-  <span class="yarn-label secondary">
-    <span class="label-key">configured capacity</span>
-    <span class="label-value">{{data.capacity}}%</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">configured max capacity</span>
-    <span class="label-value">{{data.maxCapacity}}%</span>
-  </span>
-</div>
-{{/if}}
+  </li>
+
+
+  {{#if data.isWeightMode}}
+
+    <li class="yarn-list">
+      <span class="label-key" title="Configured Weight">weight:</span>
+      <span class="label-value">{{data.weight}}</span>
+    </li>
+    <li class="yarn-list">
+      <span class="label-key" title="Normalized Weight">normalized 
weight:</span>
+      <span class="label-value">{{data.normalizedWeight}}</span>
+    </li>
+
+  {{else}}
+
+    {{!
+    
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition[2]/capacity[text()='85.44922']
+    }}
+    <li class="yarn-list">
+      <span class="label-key" title="Configured Capacity: percentage = 
'configured memory of the queue' / 'total available memory for the partition' * 
100">configured capacity:</span>

Review Comment:
   You are right @brumi1024 , in the case of the dominant resource calculator, 
it would be misleading. For brevity, swapping the word "memory" to "resources" 
throughout the template.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to